Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
celutz
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • FFDN
  • celutz
  • Issues
  • #6

Closed
Open
Opened Oct 22, 2015 by zorun@zorunOwner

General cleanup of the frontend js code

The current js code is a mess. Some specific issues:

  • it should use the json API to get information about the panorama to display, instead of using javascript variable generated from a template.

  • it is primarily designed for 360° pictures, and does not handle non-360° pictures very well (see issue #1).

  • it implements its own tile display logic, while there probably are libraries to do that.

  • there are multiple systems of coordinates, with conversions between them:

    • the backend uses absolute pixel coordinates (x/y) to refer to points in an image.
    • the frontend uses relative coordinates (x between 0 and 1, y between -0.5 and 0.5) to refer to points in an image.
    • the frontend also uses screen-based coordinates, in pixels. The relation between screen coordinates and image coordinates depends on the zoom level and the current position in the image, and wraps around for 360° images.
    • both frontend and backend also manipulate azimuth and elevation (but that's the point of celutz)
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ffdn/celutz#6